-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clickhouse policy to the db #6862
Conversation
Add fields for target deployments, which made me change my mind on naming.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, basically all nitpicks.
Should this PR update PlanningInputFromDb
to read this table?
Yes. Yes it should! Thanks for the reminder. |
Done in add2874 |
This enables us to enable and disable both clickhouse clusters and single-node clickhouse zones.
We anticipate few changes to this policy and so we maintain a complete history indexed by version. We only allow updates via a single version increment, and we guarantee consistency by ensuring the previous version is the latest version in the database while updating.